Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial medusa support for the CI #36

Merged
merged 27 commits into from
May 29, 2024
Merged

Initial medusa support for the CI #36

merged 27 commits into from
May 29, 2024

Conversation

ggrieco-tob
Copy link
Member

@ggrieco-tob ggrieco-tob commented Jun 27, 2023

This PR contains the initial integration on the use of medusa for crytic/properties. This includes the execution of ERC20 and ERC4626 tests. A few points should be addressed in future PRs:

  • Medusa config files should be placed in the root directory, to avoid hitting this issue.
  • There is no mention in the README about medusa: explaining how to use medusa requires to show/explain how the config options are used, however, this will force us to include the full json with all the default values (or medusa will crash). I reported this issue here.
  • The ERC4626 foundry tests require to disable stopOnFailedContractMatching but it is unclear why or how the user should be notified about it. This issue was reported here.

@ggrieco-tob ggrieco-tob merged commit f1ff61b into main May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant