more robust fix

crytic · Jan 9, 2024 · 62e58c4 · 62e58c4
1 parent a8581de
commit 62e58c4
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/pkg/health/ethereum/execution_rpc.go b/pkg/health/ethereum/execution_rpc.go
@@ -40,11 +40,15 @@ func (c *ExecRpcClient) GetLatestBlockBy(ctx context.Context, blockType string)
 			"Unknown block error",       //nethermind
 			"unknown block",             //reth
 		}
-		if err.Error() == notFinalizingErrors[0] ||
-			err.Error() == notFinalizingErrors[1] ||
-			err.Error() == notFinalizingErrors[2] ||
-			err.Error() == notFinalizingErrors[3] ||
-			err.Error() == notFinalizingErrors[4] {
+		noFinalBlockFound := false
+		for _, msg := range notFinalizingErrors {
+			if err.Error() == msg {
+				noFinalBlockFound = true
+				break
+			}
+		}
+
+		if noFinalBlockFound {
 			choice = &ClientForkChoice{
 				Pod:         c.session.Pod,
 				BlockNumber: 0,