Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate theme customisation for Crystall Edge #785

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MetalSage
Copy link
Contributor

About the PR

Added a separate hud customisation option for Crystal Edge themes
Добавлен отдельный параметр настройки hud для тем Crystal Edge

Media

image

@@ -11,6 +11,11 @@ public sealed partial class HudThemePrototype : IPrototype, IComparable<HudTheme
[IdDataField]
public string ID { get; private set; } = string.Empty;

// CP14-Theme-Start
[DataField]
public bool IsCP { get; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public bool IsCP { get; }
public bool CP14Allowed { get; }

Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


MetalSage seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@TheShuEd
Copy link
Contributor

Еще момент: у нас теперь есть 2 отдельных вида файлов CVar. Один является партиалом от базовых оффовских CVar который делал я, и второй твой ноовый CP14Config. Нужно это как то слить, пока оно не разраслось, выбрав лучший вариант.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants