Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic traces WIP #591

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Magic traces WIP #591

wants to merge 4 commits into from

Conversation

TheShuEd
Copy link
Contributor

About the PR

Магия оставляет следы

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link
Contributor

github-actions bot commented Dec 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.


private bool _markersVisible;

public bool MarkersVisible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем два свойства вместо одного?

if (_timing.CurTime < _nextUpdate)
return;

_nextUpdate = _timing.CurTime + TimeSpan.FromSeconds(0.5f);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic 🪄

@@ -48,13 +49,26 @@
sound: !type:SoundPathSpecifier
path: /Audio/Magic/rumble.ogg
icon:
sprite: _CP14/Effects/Magic/spells_icons.rsi
sprite: _CP14/Effects/Magic/spells_icons.rsi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants