Update drinks_cups.yml #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheShuEd
requested changes
Nov 10, 2024
github-actions
bot
added
Status: Needs Review
and removed
Status: Awaiting Changes
labels
TheShuEd
reviewed
Nov 10, 2024
| @@ -1,7 +1,7 @@ | |||
| #Base for future bottles | |||
| - type: entity | |||
| name: Green Bottle | |||
| parent: CP14BaseVial | |||
| parent: [CP14BaseVial, CP14BaseVialFragile] | |||
There was a problem hiding this comment.
а зачем, если CP14BaseVialFragile и так наследуется от CP14BaseVial?
There was a problem hiding this comment.
А там разбиваемое стекло
There was a problem hiding this comment.
разницы короче нету, что так и что так. Я просто много не думал
There was a problem hiding this comment.
Хоть поставить без CP14BaseVial
There was a problem hiding this comment.
Я знаю, но я подал так с другой точки зрения. хотя и так и так будет работать, можно сказать я не внимательный.
|
благодарим-с |
TheShuEd
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Просто заменил
parentи всё корректно заработало.Везде кружки CP14 работают теперь. А я парился над этим 2-3 часа.
fix #563 @TheShuEd