-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Github Action to build Darwin packages. #288
base: master
Are you sure you want to change the base?
Conversation
c43b020
to
851ea63
Compare
Allow to run build scripts for darwin to test changes in PR.
851ea63
to
4dfb339
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a few typos.
Versions should eventually be updated when/if this will be merged.
CRYSTAL_VERSION=1.11.0 \ | ||
PACKAGE_ITERATION=1 \ | ||
LLVM_VERSION=15.0.7 \ | ||
PREVIOUS_CRYSTAL_RELEASE_DARWIN_TARGZ=https://github.com/crystal-lang/crystal/releases/download/1.10.1/crystal-1.10.1-1-darwin-universal.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Crystal and LLVM versions should be updated. I believe we just upgraded to LLVM 18?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ysbaddaden i think I asked @straight-shoota about this 1 year ago :)
If I build crystal in macos with hombrew - it used LLVM 17, but for Darwin package it was old 15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to review it again, to check if it was any changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's why I said if/when this is merged. Don't bother with this now :)
Co-authored-by: Julien Portalier <[email protected]>
Co-authored-by: Julien Portalier <[email protected]>
Co-authored-by: Julien Portalier <[email protected]>
Allow to run build scripts for darwin to test changes in PR.
Tests
Run a build: https://github.com/miry/distribution-scripts/actions/runs/7476572158
Download the artifact and checked arch:
PS: Feel free to modify the code or propose any changes, especially in Github action names.