Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Github Action to build Darwin packages. #288

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

miry
Copy link
Contributor

@miry miry commented Jan 10, 2024

Allow to run build scripts for darwin to test changes in PR.

Tests

Run a build: https://github.com/miry/distribution-scripts/actions/runs/7476572158

Download the artifact and checked arch:

$ file embedded/bin/crystal 
embedded/bin/crystal: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64]
embedded/bin/crystal (for architecture x86_64):	Mach-O 64-bit executable x86_64
embedded/bin/crystal (for architecture arm64):	Mach-O 64-bit executable arm64

$ ./embedded/bin/crystal --version
Crystal 1.12.0-dev [0b57b6cc8] (2024-01-09)

LLVM: 15.0.7
Default target: aarch64-apple-darwin

PS: Feel free to modify the code or propose any changes, especially in Github action names.

Allow to run build scripts for darwin to test changes in PR.
Copy link

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a few typos.

Versions should eventually be updated when/if this will be merged.

.github/workflows/darwin_build.yml Outdated Show resolved Hide resolved
.github/workflows/darwin_build.yml Outdated Show resolved Hide resolved
.github/workflows/darwin_build.yml Outdated Show resolved Hide resolved
Comment on lines +70 to +73
CRYSTAL_VERSION=1.11.0 \
PACKAGE_ITERATION=1 \
LLVM_VERSION=15.0.7 \
PREVIOUS_CRYSTAL_RELEASE_DARWIN_TARGZ=https://github.com/crystal-lang/crystal/releases/download/1.10.1/crystal-1.10.1-1-darwin-universal.tar.gz

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Crystal and LLVM versions should be updated. I believe we just upgraded to LLVM 18?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysbaddaden i think I asked @straight-shoota about this 1 year ago :)
If I build crystal in macos with hombrew - it used LLVM 17, but for Darwin package it was old 15.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to review it again, to check if it was any changes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's why I said if/when this is merged. Don't bother with this now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants