-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.0-pre1 #9892
Release 1.0.0-pre1 #9892
Conversation
Is it planned to have both Logger and Log for the 1.0? I find it quite confusing, last day I used Logger by mistake. |
@j8r Isn't |
Ho right @Sija , I didn't noticed it, being "still" in 0.35.1. Great then 👍 |
This is totally optional and my personal opinion, but... I think the Changelog should be more oriented toward a user of the language reading it. Right now it contains things like "Fixed example code" or "Fix typos and misspelling" or "Make socket a bit more type friendly" (this is an internal refactor not visible to users). That probably has no impact on users. I mean, they are good things, but they are not actionable. With an item like "Change method X to do Y" the user will think "Oh, I need to update this code" or "Oh, now I can use this method for this different thing", but with "Fixed typos" or "Internal refactor" they can't do anything about it. If users want that level of details they can go to the commit log. In the past I kept the Changelog user-oriented. |
@asterite I agree that the changelog is probably not that useful to users of the language. The question is: should it be? Yes, users need to get the information about changes to the language / stdlib that affect them. But that doesn't need to be in the changelog of this repository, which is just an internal tool. So documentation of changes is focused on internal view. P.S. Somewhat related proposal: crystal-lang/crystal-website#119 |
@straight-shoota I don't understand. If the changelog is just an internal tool, and a commit log fulfills that need just as well, then what's the point? |
I don't think the commit log fulfills that purpose well at all. It's noisy, unstructured, immutable, etc. |
IMO the changelog is for people that want to know details of the project development but not too many details/noise as a git log. Language users usually read the official blog post that describe the language changes with examples and better explanations longer than a single line. So IMO the current format is ok. |
I will reopen it again as 0.36 later |
Preview at https://github.com/bcardiff/crystal/blob/changelog/1.0.0-pre1/CHANGELOG.md
There are a couple of more PRs that will land in 1.0.0-pre1, no worries :-)
The 1.0.0-pre1 will be the first unstable release as stated in https://crystal-lang.org/2020/08/24/announcing-new-apt-and-rpm-repositories.html