-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add :showdoc:
directive (RFC #11)
#15294
base: master
Are you sure you want to change the base?
Add :showdoc:
directive (RFC #11)
#15294
Conversation
Add support for showing lib / fun / type / cstruct / union in docs
… in a :showdoc: class
b751070
to
cd722b6
Compare
(apologies for force push, force of habit) |
That looks pretty good and seems to do the job well 👍 |
Given this PR is implementing an RFC for |
What stuff are you referring to? |
From what I can tell this is also enabling doc support on |
Yes that's true. I'm fine splitting it into two PRs, but enabling documentation support for lib types was the original purpose for the |
I think splitting this into separate PRs is a good idea. The changes are all working towards the goal to support API docs for lib bindings. But they're not directly related. The doc generator changes and the parser changes for example do not strictly depend on each other. We can merge either one individually and have a subset of features available. |
Sounds good. How should I go about splitting this PR? As we discourage force-pushing, my thought is closing this PR and opening two others (one for lib docs, another for showdoc directive) |
Implements RFC#0011.
Starting as a draft for now to get feedback.