Use #exit_signal? in stdlib

crystal-lang · Dec 17, 2024 · ec05412 · ec05412
1 parent 27b081b
commit ec05412
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/src/compiler/crystal/command.cr b/src/compiler/crystal/command.cr
@@ -316,8 +316,7 @@ class Crystal::Command
   private def exit_message(status)
     case status.exit_reason
     when .aborted?, .session_ended?, .terminal_disconnected?
-      if status.signal_exit?
-        signal = status.exit_signal
+      if signal = status.exit_signal?
         if signal.kill?
           "Program was killed"
         else

diff --git a/src/process/status.cr b/src/process/status.cr
@@ -292,10 +292,10 @@ class Process::Status
     {% if flag?(:win32) %}
       @exit_status.to_s(io)
     {% else %}
-      if normal_exit?
-        exit_code.inspect(io)
+      if signal = exit_signal?
+        signal.inspect(io)
       else
-        exit_signal.inspect(io)
+        exit_code.inspect(io)
       end
     {% end %}
     io << "]"
@@ -309,15 +309,14 @@ class Process::Status
     {% if flag?(:win32) %}
       @exit_status.to_s(io)
     {% else %}
-      if normal_exit?
-        io << exit_code
-      else
-        signal = exit_signal
+      if signal = exit_signal?
         if name = signal.member_name
           io << name
         else
           signal.inspect(io)
         end
+      else
+        io << exit_code
       end
     {% end %}
   end
@@ -330,11 +329,10 @@ class Process::Status
     {% if flag?(:win32) %}
       @exit_status.to_s
     {% else %}
-      if normal_exit?
-        exit_code.to_s
-      else
-        signal = exit_signal
+      if signal = exit_signal?
         signal.member_name || signal.inspect
+      else
+        exit_code.to_s
       end
     {% end %}
   end