Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding empty image for sponsor with no logo #797

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

beta-ziliani
Copy link
Member

Replaces #795

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for crystal-website ready!

Name Link
🔨 Latest commit a2fd7ca
🔍 Latest deploy log https://app.netlify.com/sites/crystal-website/deploys/665f6f300801350008b2a20c
😎 Deploy Preview https://deploy-preview-797--crystal-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@straight-shoota
Copy link
Member

I believe it would be easier to assign the empty logo in the sponsor data. We should be able to do that by putting a metching entry with logo in _data/others.json.
This would avoid introducing more complexity into the template. This can be handled on the data side, so it's best to do it there.

Also this particular SVG is certainly not approvable.
I would consider keeping it completely blank maybe?

@beta-ziliani
Copy link
Member Author

Done that, although the merge system is not great for this. We should implement a better strategy in the future; one that doesn't require so many fields when just needing to override one.

@straight-shoota
Copy link
Member

@beta-ziliani I understand partial merge should work with overrides property... I believe it did in the past. But might need to look into. We can merge this of course.

@beta-ziliani beta-ziliani merged commit aae7825 into crystal-lang:master Jun 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants