Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sponsors #792

Merged
merged 1 commit into from
May 24, 2024
Merged

Updating sponsors #792

merged 1 commit into from
May 24, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

Copy link

netlify bot commented May 23, 2024

Deploy Preview for crystal-website ready!

Name Link
🔨 Latest commit c15f1f5
🔍 Latest deploy log https://app.netlify.com/sites/crystal-website/deploys/6650d4b41b3461000857f69a
😎 Deploy Preview https://deploy-preview-792--crystal-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@straight-shoota
Copy link
Member

Should we really list refunds as negative contributions?

grafik

This can signal a wrong message that they're taking money out of the project. Intstead they're just recalling their previous contribution (for whatever reason, which might be of a technical nature) which is a net zero for the project.
So I think it would be better to show this month's contribution as 0 instead of a negative value.

@beta-ziliani
Copy link
Member

Fixed in #793

@beta-ziliani beta-ziliani merged commit 72b0b56 into master May 24, 2024
4 checks passed
@@ -1,3 +1,4 @@
logo,name,url,last_payment,all_time,since,level
sponsors/84.png,84codes,https://www.84codes.com/,"€22,000","€369,000","Apr 1, 2018",5000
manas-orange.svg,Manas.Tech,https://manas.tech/,"$5,000","$1,300,000","Jun 19, 2009",5000
,Austin Robert Bales,https://arbales.me/,"$1,234","$1,234","May 4, 2024",1000
Copy link
Member

@straight-shoota straight-shoota May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke the expectation that big logo sponsors actually have a logo.

grafik

Now the link checker is broken: https://github.com/crystal-lang/crystal-website/actions/runs/9228044592/job/25391263090
Apparently these CI jobs were not run on the PR for some reason, so it was all green before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants