Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for showing end location marker #200

Merged
merged 9 commits into from
Jan 26, 2021
Merged

Add support for showing end location marker #200

merged 9 commits into from
Jan 26, 2021

Conversation

Sija
Copy link
Member

@Sija Sija commented Jan 22, 2021 •
edited
Loading

Code would welcome bit of DRY-ness but first I wanted to see whether this PR gain any traction.

  • DotFormatter:

    image

  • ExplainFormatter:

    image

@Sija Sija requested a review from veelenga January 22, 2021 17:02
@Sija Sija self-assigned this Jan 22, 2021
veelenga
veelenga reviewed Jan 22, 2021
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks interesting. What do you think about a small adjustment to the formatting:

before:

a = "very long text"
     ^------------^

after:

a = "very long text"
     ^^^^^^^^^^^^^^

@Sija
Copy link
Member Author

Sija commented Jan 22, 2021

@veelenga I've tried but with bigger amount of occurrences it becomes an annoyance:

image

@Sija Sija force-pushed the feature/show-end-location-marker branch 3 times, most recently from 18bf90b to ca03994 Compare January 23, 2021 03:06
@Sija Sija marked this pull request as ready for review January 23, 2021 03:16
Sija added 2 commits January 23, 2021 12:30
@Sija
Add support for showing end location marker
94e44b1
@Sija
Cleanup Reportable method definitions
ded60b4 
There’s no need for double splats, since they mess up method resolution, and obscure the actual - single (!) - argument - `status`, so… be gone

Also, all of the helpers return the constructed `Issue` like a behaving good methods.
@Sija Sija force-pushed the feature/show-end-location-marker branch from e55ff5a to bfbb4f9 Compare January 23, 2021 11:30
@Sija Sija requested a review from veelenga January 23, 2021 11:30
@Sija
Copy link
Member Author

Sija commented Jan 23, 2021

Preview of the current version:

image

veelenga
veelenga reviewed Jan 23, 2021
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Could you please cover this by specs, especially the new utility methods.

@Sija Sija force-pushed the feature/show-end-location-marker branch from bfbb4f9 to fa97014 Compare January 24, 2021 00:12
@Sija Sija force-pushed the feature/show-end-location-marker branch from fa97014 to 1a04b45 Compare January 24, 2021 00:39
@Sija Sija requested a review from veelenga January 24, 2021 00:43
Sija added 2 commits January 25, 2021 01:32
@Sija
Refactor DotFormatter a bit
6f24b12 
Make text format moar in line with Crystal spec runner.
@Sija
Update README.md
c03ac74
@Sija Sija force-pushed the feature/show-end-location-marker branch from 1a04b45 to c03ac74 Compare January 25, 2021 00:32
@veelenga veelenga merged commit ea98554 into develop Jan 26, 2021
@veelenga veelenga deleted the feature/show-end-location-marker branch January 26, 2021 06:38
@Sija Sija mentioned this pull request Feb 11, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sija @veelenga