Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt ed25519 tests to top-level crate API #825

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Adapt ed25519 tests to top-level crate API #825

merged 6 commits into from
Feb 13, 2025

Conversation

wysiwys
Copy link
Contributor

@wysiwys wysiwys commented Feb 13, 2025

This PR adds tests for the libcrux-ed25519 crate, adapted from the tests in tests/ed25519.rs.

  • Skips wycheproof tests whose provided signature has a length not equal to 64 bytes
  • Skips wycheproof test groups whose provided private key has a length not equal to 32 bytes

Resolves #798

@wysiwys wysiwys requested a review from a team as a code owner February 13, 2025 08:23
jschneider-bensch
jschneider-bensch previously requested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! I just have one more idea to make sure we get the intent of the skipped tests right.

ed25519/tests/ed25519.rs Show resolved Hide resolved
@wysiwys wysiwys self-assigned this Feb 13, 2025
jschneider-bensch
jschneider-bensch approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get it merged.

@jschneider-bensch jschneider-bensch merged commit 2611285 into main Feb 13, 2025
65 checks passed
@jschneider-bensch jschneider-bensch deleted the wysiwys/update-ed25519-tests branch February 13, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschneider-bensch jschneider-bensch jschneider-bensch approved these changes

Assignees

@wysiwys wysiwys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt tests in ed25519.rs
2 participants
@wysiwys @jschneider-bensch