Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AEAD Benchmarks to use libcrux-chacha20poly1305 crate #810

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Update AEAD Benchmarks to use libcrux-chacha20poly1305 crate #810

merged 5 commits into from
Feb 12, 2025

Conversation

keks
Copy link
Member

@keks keks commented Feb 11, 2025

Fixes #762

@keks keks requested a review from a team as a code owner February 11, 2025 16:20
@keks keks requested a review from wysiwys February 11, 2025 16:29
wysiwys
wysiwys approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@wysiwys wysiwys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

jschneider-bensch
jschneider-bensch approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good to me, as well! With a tiny, totally optional nit. :)

benchmarks/benches/aead.rs Outdated Show resolved Hide resolved
@keks keks enabled auto-merge February 12, 2025 14:31
@keks keks merged commit 22aafcc into main Feb 12, 2025
64 of 65 checks passed
@keks keks deleted the keks/bench-chachapoly branch February 12, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschneider-bensch jschneider-bensch jschneider-bensch approved these changes

@wysiwys wysiwys wysiwys approved these changes

Assignees

@keks keks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chacha20Poly1305 benchmarks
3 participants
@keks @jschneider-bensch @wysiwys