Fix SIGSEV crashes by adding NULL pointer checks #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overheadhunter
requested changes
Oct 19, 2023
jfuse-api/src/main/java/org/cryptomator/jfuse/api/util/MemoryUtils.java
Outdated
Show resolved
Hide resolved
|
Also, can you add tests for the new utility methods? |
In fuse 2 the above methods either do not have a file info as parameter or the documentation only mentions the path to be nullable. |
…tils.java Co-authored-by: Sebastian Stenzel <[email protected]>
@overheadhunter Done in c3bb154 |
overheadhunter
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the fuse 3.x documentation, the methods
releasedir,getattr,chmod,chown,fsyncdir,truncateandutimenscan have NULL parameter. Before this PR this was not accounted for, leading to crashes of the JVM.This PR fixes it. If the MemorySegment handed over to the JVM is the NULL-Pointer, the methods translate it to Javas
nullvalue.