Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build project with JDK 22 #63

Merged
merged 2 commits into from
May 16, 2024
Merged

Build project with JDK 22 #63

merged 2 commits into from
May 16, 2024

Conversation

infeo
Copy link
Member

@infeo infeo commented May 16, 2024

Account for JDK-8308398, but keep multi release jar.

@infeo infeo requested a review from overheadhunter May 16, 2024 11:02
@infeo infeo self-assigned this May 16, 2024
Copy link

coderabbitai bot commented May 16, 2024

Walkthrough

The recent updates involve upgrading the Java version from 21 to 22 across various configuration files. This change is prominent in GitHub Actions workflows, project settings, and the pom.xml file. Additionally, a new module-info.java file has been added to support Java 22, defining cryptographic API dependencies, exports, and implementations.

Changes

Files Change Summary
.github/workflows/build.yml Updated Java version from 21 to 22
.github/workflows/codeql-analysis.yml Updated Java version from 21 to 22
.github/workflows/dependency-check.yml Updated Java version from 21 to 22
.github/workflows/publish-central.yml Updated Java version from 21 to 22
.github/workflows/publish-github.yml Updated Java version from 21 to 22
.idea/misc.xml Changed project-jdk-name from "21" to "22"
pom.xml Added execution block for Java 22 compilation; updated arguments for META-INF/versions/22
src/main/java22/module-info.java Introduced module with cryptographic API, dependencies, exports, and implementations

🐇 In the realm of code so grand,
Java 22 takes its stand.
Workflows, settings all in tune,
Projects blooming like in June.
Cryptic modules now in play,
CodeRabbit cheers, "Hooray!"
With every byte, we pave the way. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 4db325b and 10ddab6.
Files selected for processing (8)
  • .github/workflows/build.yml (1 hunks)
  • .github/workflows/codeql-analysis.yml (1 hunks)
  • .github/workflows/dependency-check.yml (1 hunks)
  • .github/workflows/publish-central.yml (1 hunks)
  • .github/workflows/publish-github.yml (1 hunks)
  • .idea/misc.xml (1 hunks)
  • pom.xml (2 hunks)
  • src/main/java22/module-info.java (1 hunks)
Files skipped from review due to trivial changes (4)
  • .github/workflows/build.yml
  • .github/workflows/codeql-analysis.yml
  • .github/workflows/publish-github.yml
  • .idea/misc.xml
Additional comments not posted (4)
.github/workflows/dependency-check.yml (1)

17-17: LGTM! The Java version has been correctly updated to 22.

src/main/java22/module-info.java (1)

1-27: The module descriptor for Java 22 is well-structured and aligns with the project's requirements.

pom.xml (2)

174-187: The new execution block for Java 22 compilation is correctly configured.


245-245: The update to reference META-INF/versions/22/module-info.class is appropriate.

.github/workflows/publish-central.yml Show resolved Hide resolved
Copy link
Member

@overheadhunter overheadhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maven-enforcer-plugin should be updated as well, if we require JDK 22 now.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 10ddab6 and 50c34ad.
Files selected for processing (1)
  • pom.xml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • pom.xml

@infeo infeo requested a review from overheadhunter May 16, 2024 14:51
@infeo infeo merged commit 42625ff into develop May 16, 2024
5 checks passed
@infeo infeo deleted the feature/jdk22 branch May 16, 2024 14:55
@infeo infeo mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants