Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: gomod2nix don't use the same golang version as project #853

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Problem: gomod2nix don't use the same golang version as project #853

merged 2 commits into from
Sep 5, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 2, 2022 •
edited
Loading

Solution:

  • build updateScript in nix expression.
  • add workflow to check gomod2nix.toml up to date.
  • update gomod2nix to upstream master branch.

Now, one should run nix run .#update-gomod2nix to update gomod2nix, rather than run gomod2nix directly, a direct run will always use go 1.17.

After nix-community/gomod2nix#92 merged, we'll be able to use the builtin script, for now we'll use the custom one.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang
Problem: gomod2nix don't use the same golang version as project
7715b71 
Solution:
- build updateScript in nix expression.
- add workflow to check gomod2nix.toml up to date.
@yihuang yihuang requested a review from a team as a code owner September 2, 2022 07:24
@codecov
Copy link

codecov bot commented Sep 2, 2022 •
edited
Loading

Codecov Report

Merging #853 (00cfb22) into master (4b0c725) will decrease coverage by 1.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
- Coverage   18.28%   16.62%   -1.66%     
==========================================
  Files          97       92       -5     
  Lines       12530    11621     -909     
==========================================
- Hits         2291     1932     -359     
+ Misses       9744     9234     -510     
+ Partials      495      455      -40
Flag Coverage Δ
integration_tests 16.62% <ø> (ø)
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/icaauth/types/types.go 0.00% <0.00%> (-100.00%) ⬇️
x/nft/keeper/owners.go 17.02% <0.00%> (-68.09%) ⬇️
x/nft/keeper/collection.go 23.18% <0.00%> (-49.28%) ⬇️
x/nft/client/cli/query.go 27.71% <0.00%> (-39.14%) ⬇️
x/nft/keeper/grpc_query.go 5.88% <0.00%> (-37.82%) ⬇️
x/nft/keeper/denom.go 51.28% <0.00%> (-33.34%) ⬇️
x/nft/client/cli/tx.go 43.02% <0.00%> (-30.42%) ⬇️
x/icaauth/types/message_register_account.go 0.00% <0.00%> (-25.00%) ⬇️
x/nft/keeper/keeper.go 59.42% <0.00%> (-21.64%) ⬇️
x/nft/types/msgs.go 50.00% <0.00%> (-15.00%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@devashishdxt
Copy link
Collaborator

Can we merge this @yihuang?

@yihuang
Copy link
Collaborator Author

yihuang commented Sep 5, 2022

Can we merge this @yihuang?

sure

@yihuang yihuang merged commit a3ec407 into crypto-org-chain:master Sep 5, 2022
@yihuang yihuang deleted the update-gomod2nix branch September 5, 2022 01:34
devashishdxt pushed a commit to devashishdxt/chain-main that referenced this pull request Sep 23, 2022
@yihuang @devashishdxt
Problem: gomod2nix don't use the same golang version as project (cryp…
ad45150 
…to-org-chain#853)

* Problem: gomod2nix don't use the same golang version as project

Solution:
- build updateScript in nix expression.
- add workflow to check gomod2nix.toml up to date.

* tweag -> nix-community
tomtau pushed a commit that referenced this pull request Sep 23, 2022
@yihuang @tomtau
Problem: gomod2nix don't use the same golang version as project (#853)
a8d5592 
* Problem: gomod2nix don't use the same golang version as project

Solution:
- build updateScript in nix expression.
- add workflow to check gomod2nix.toml up to date.

* tweag -> nix-community
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devashishdxt devashishdxt devashishdxt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @devashishdxt