Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GetHostConfig function #9

Closed
wants to merge 5 commits into from

Conversation

muneebkq
Copy link
Collaborator

GetHostConfig to retrieve the host configuration from LexFloatServer. The function sends a network request to get the configuration details and returns the result as a JSON string. The JSON string is then parsed and stored in a HostConfig struct.

@muneebkq muneebkq requested a review from ahmad-kemsan July 16, 2024 09:08
@muneebkq muneebkq changed the base branch from main to borrowing-develop August 1, 2024 04:11
LF_E_INET, LF_E_CLIENT, LF_E_IP, LF_E_SERVER
*/
LEXFLOATCLIENT_API int LF_CC GetHostConfigInternal(STRTYPE hostConfigPtr, uint32_t length);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muneebkq hostConfigPtr -> hostConfig

RETURN CODES: LF_OK, LF_E_PRODUCT_ID, LF_E_HOST_URL, LF_E_BUFFER_SIZE
LF_E_INET, LF_E_CLIENT, LF_E_IP, LF_E_SERVER
*/
func GetHostConfig(hostConfig *HostConfig) int {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muneebkq The formatting does not seem to be right. Plus, remove extra lines

LF_E_INET, LF_E_CLIENT, LF_E_IP, LF_E_SERVER
*/
func GetHostConfig(hostConfig *HostConfig) int {
var chostConfig = getCArray()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muneebkq chostConfig -> cHostConfig

Copy link
Collaborator

@ahmad-kemsan ahmad-kemsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

@muneebkq muneebkq closed this Aug 6, 2024
@muneebkq muneebkq deleted the muneeb/get-host-config branch January 17, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants