Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GetFloatingLicenseMode function #12

Merged
merged 7 commits into from
Aug 6, 2024

Conversation

muneebkq
Copy link
Collaborator

GetFloatingLicenseMode to the codebase. This function allows retrieving the mode of the floating license (online or offline). The function takes a pointer to a buffer and the size of the buffer as parameters. The function returns LF_OK if successful, LF_E_PRODUCT_ID if the product ID is invalid, LF_E_NO_LICENSE if no license is found, and LF_E_BUFFER_SIZE if the buffer size is insufficient.

@muneebkq muneebkq requested a review from ahmad-kemsan July 16, 2024 09:13
@muneebkq muneebkq changed the base branch from main to borrowing-develop August 1, 2024 04:12
@@ -40,7 +40,7 @@ func floatingLicenseCallbackWrapper(status int) {

PARAMETERS:
* productId - the unique product id of your application as mentioned
on the product page in the dashboard.
on the product page in the dashboard.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muneebkq No need for this change.

var cLibraryVersion = getCArray()
status := C.GetFloatingClientLibraryVersion(&cLibraryVersion[0], maxCArrayLength)
*libraryVersion = ctoGoString(&cLibraryVersion[0])
return int(status)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muneebkq Is this the UI reflecting this or was the indentation by mistake added here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was no proper indentation earlier

RETURN CODES: LF_OK, LF_E_PRODUCT_ID, LF_E_NO_LICENSE, LF_E_BUFFER_SIZE
*/

func GetFloatingLicenseMode(modePtr *string) int {
Copy link
Collaborator

@ahmad-kemsan ahmad-kemsan Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muneebkq Extra line between the docs and function. Also here we do not use the Ptr in the param across the go wrappers. Please check the other similar functions

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@ahmad-kemsan ahmad-kemsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

@ahmad-kemsan ahmad-kemsan merged commit 913664b into borrowing-develop Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants