Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name to Symbols List #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Name to Symbols List #16

wants to merge 3 commits into from

Conversation

PerrySong
Copy link

It would be nice if it can build a JSON file that maps the coins' name to symbols. I added a few lines in build.js, and it will create name-to-symbol.js by running $ npm run build

@crypti crypti deleted a comment from PerrySong Jul 8, 2018
@radiovisual
Copy link
Member

Thanks for the contribution!

I don't mind having an extra data set generated for those that would prefer to have the ability to look up symbols by their respective currency name, so can you add a section to the README which discusses the generated file, with an example of how to use it?

Thanks!

P.S: I deleted one of your comments above because there were two comments with the same content.

@radiovisual
Copy link
Member

And you will want to add a unit test. Nothing elaborate, just a check to ensure that nothing we do causes a regression or a break the expected formatting of the object.

@radiovisual radiovisual changed the title Add fuctionality Name to Symbols List Jul 22, 2018
@pml106288
Copy link

RBTQ Realbank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants