Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deploy): split Deployments #1009

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat(deploy): split Deployments #1009

wants to merge 15 commits into from

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jan 14, 2025 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #814
Includes:

Description of the change:

This change adds allows the users to provide...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Insert steps here...
  2. ...

@mergify mergify bot added the safe-to-test label Jan 14, 2025
@andrewazores andrewazores added the feat New feature or request label Jan 14, 2025
@andrewazores andrewazores marked this pull request as draft January 14, 2025 21:34
@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

/build_test completed successfully ✅.
View Actions Run.

andrewazores and others added 8 commits January 22, 2025 14:42
@andrewazores
feat(network): implement network policy for Agent gateway (#1022)
c2309aa
@andrewazores
Merge branch 'main' into split-deployment
099f7c2
@andrewazores @ebaron
feat(db): enable JDBC TLS configuration (#1019)
af9bfb5 
Co-authored-by: Elliott Baron <[email protected]>
@dependabot @andrewazores
build(deps): bump sigs.k8s.io/controller-runtime from 0.18.6 to 0.18.7 (
c84e885 
#999)

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.18.6 to 0.18.7.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.18.6...v0.18.7)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@andrewazores
Merge branch 'main' into split-deployment
c66e9f5
@andrewazores @ebaron
feat(storage): enable storage TLS configuration (#1020)
392d7a6 
Co-authored-by: Elliott Baron <[email protected]>
@andrewazores
Merge branch 'main' into split-deployment
f6e925f
@andrewazores @ebaron
feat(pvc): split PVCs for database and storage (#1010)
cb835b8 
Co-authored-by: Elliott Baron <[email protected]>
@andrewazores andrewazores marked this pull request as ready for review January 24, 2025 20:53
@andrewazores
Copy link
Member Author

@ebaron unless you think #1024 is worth getting done (I think it's fine to hold until later, and then we can also implement CRD API for the URI range controls) then this should be ready to go. It's just a roll-up of the PRs listed in the PR body, which were all getting resynced with this and main as things went on, so this should be identical to the split-pvcs PR that went in last.

@ebaron
Copy link
Member

ebaron commented Jan 24, 2025

@ebaron unless you think #1024 is worth getting done (I think it's fine to hold until later, and then we can also implement CRD API for the URI range controls) then this should be ready to go. It's just a roll-up of the PRs listed in the PR body, which were all getting resynced with this and main as things went on, so this should be identical to the split-pvcs PR that went in last.

I vote for holding off on #1024 for 4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat New feature or request safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Story] Deploy database and storage containers separately
3 participants
@andrewazores @ebaron @mwangggg