Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate code to Java 17 standard and cleanup code #197

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

agrancaric
Copy link
Collaborator

@agrancaric agrancaric commented Jan 23, 2024

Basic information

  • nrich version:
    2.7.0
  • Module:
    project

Additional information

Description

Summary

Migrate code to Java 17 style and cleanup code where applicable.

Details

Migrate code to Java 17 style and cleanup code where applicable.

Related issue

Types of changes

  • Breaking change (fix, enhancement or feature that would cause existing functionality to change in backward-incompatible way)
  • Refactoring

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: Patch coverage is 98.64407% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.64%. Comparing base (71e0bc2) to head (6826c48).
Report is 8 commits behind head on master.

Current head 6826c48 differs from pull request most recent head 4996b68

Please upload reports for the commit 4996b68 to get more accurate results.

Files Patch % Lines
...t/croz/nrich/encrypt/aspect/EncryptDataAspect.java 75.00% 0 Missing and 1 partial ⚠️
...nrich/encrypt/aspect/EncryptMethodInterceptor.java 85.71% 0 Missing and 1 partial ⚠️
...nrich/excel/generator/PoiExcelReportGenerator.java 80.00% 0 Missing and 1 partial ⚠️
...history/service/DefaultRegistryHistoryService.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #197      +/-   ##
============================================
- Coverage     96.69%   96.64%   -0.05%     
- Complexity     1292     1323      +31     
============================================
  Files           186      207      +21     
  Lines          2963     2924      -39     
  Branches        260      260              
============================================
- Hits           2865     2826      -39     
+ Misses           43       42       -1     
- Partials         55       56       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agrancaric agrancaric force-pushed the feature_migrateAndCleanupCodeToJava17 branch from eacca58 to 925edc6 Compare March 11, 2024 12:54
@agrancaric agrancaric force-pushed the feature_migrateAndCleanupCodeToJava17 branch 2 times, most recently from ac3fa67 to 6826c48 Compare April 4, 2024 18:25
@agrancaric agrancaric force-pushed the feature_migrateAndCleanupCodeToJava17 branch from 6826c48 to f83f21a Compare May 13, 2024 08:52
@agrancaric agrancaric force-pushed the feature_migrateAndCleanupCodeToJava17 branch from f83f21a to 4996b68 Compare May 23, 2024 05:55
@agrancaric agrancaric force-pushed the feature_migrateAndCleanupCodeToJava17 branch from 4996b68 to c70a675 Compare July 8, 2024 07:34
@agrancaric agrancaric force-pushed the feature_migrateAndCleanupCodeToJava17 branch 3 times, most recently from c0a4f7a to d74331a Compare September 23, 2024 08:19
@agrancaric agrancaric force-pushed the feature_migrateAndCleanupCodeToJava17 branch from d74331a to 7729d45 Compare September 23, 2024 08:41
@jzrilic jzrilic merged commit 6b885a8 into master Sep 23, 2024
6 checks passed
@jzrilic jzrilic deleted the feature_migrateAndCleanupCodeToJava17 branch September 23, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants