Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for rendering enviroment variables for docker compose #50

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

StevusPrimus
Copy link
Contributor

This improves the way the config can be passed via docker compose.

@StevusPrimus StevusPrimus changed the title fix for rendering fix for rendering enviroment variables for docker compose Sep 4, 2024
@StevusPrimus
Copy link
Contributor Author

@LaurenceJJones
Copy link
Contributor

LaurenceJJones commented Sep 5, 2024

Currently this will break all known Kubernetes deployments as the BOUNCER_CONFIG is currently used to update the environment to point towards a new file.

So if this is merged then all ingresses would encounter issues, I would use another environment variable name that was not existing before.

@StevusPrimus
Copy link
Contributor Author

Sure will check this!

@StevusPrimus
Copy link
Contributor Author

@LaurenceJJones do you think it is maybe better to just add all single missing parameters to the docker-start.sh, instead of using a multiline env variable? I think that's more according to standard right?

@StevusPrimus
Copy link
Contributor Author

All done. Depending on crowdsecurity/lua-cs-bouncer#75

@he2ss he2ss merged commit 61c9c27 into crowdsecurity:main Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants