Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add formatter for Juniper SRX series Firewalls which only support dynamic address lists with IP addresses (host or network) in CIDR notation. I've also updated the Docker readme to include documentation on how to use this formatter.
This can be utilised by any SRX firewall running Junos 18.4R1 or higher as per the following Junos CLI reference document:
https://www.juniper.net/documentation/us/en/software/junos/cli-reference/topics/ref/statement/dynamic-address.html
I have validated this in a lab using my own SRX running Junos 22.3R3-S1.3
Note that using this formatter successfully does require modifying the endpoint configuration value in
cfg.yaml
to include a .txt suffix for the SRX to correctly identify the format (SRX also supports multiple .txt address lists packed in the .gz archive format).I've noted this in the documentation, but this does mean that there would be a limitation in that SRX devices wouldn't support Global RunTime Query Parameters in their current format.