use golangci-lint 1.61

.github/workflows/lint.yml

@@ -37,15 +37,11 @@ jobs:
         make build
 
     - name: golangci-lint
-      uses: golangci/golangci-lint-action@v4
+      uses: golangci/golangci-lint-action@v6
       with:
-        version: v1.56
+        version: v1.61
         args: --issues-exit-code=1 --timeout 10m
         only-new-issues: false
-        # the cache is already managed above, enabling it here
-        # gives errors when extracting
-        skip-pkg-cache: true
-        skip-build-cache: true
 
     - name: Perform CodeQL Analysis
       uses: github/codeql-action/analyze@v3

.golangci.yml

@@ -144,6 +144,7 @@ linters:
 
     - gomnd                 # An analyzer to detect magic numbers.
     - ireturn               # Accept Interfaces, Return Concrete Types
+    - mnd                   # An analyzer to detect magic numbers.
     - unparam               # Reports unused function parameters
 
     #

pkg/server/logging.go

@@ -212,7 +212,7 @@ func buildCommonLogLine(req *http.Request, url url.URL, ts time.Time, status int
 	// Requests using the CONNECT method over HTTP/2.0 must use
 	// the authority field (aka r.Host) to identify the target.
 	// Refer: https://httpwg.github.io/specs/rfc7540.html#CONNECT
-	if req.ProtoMajor == 2 && req.Method == "CONNECT" {
+	if req.ProtoMajor == 2 && req.Method == http.MethodConnect {
 		uri = req.Host
 	}