Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli: remove "dashboard" command #3004

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

cscli: remove "dashboard" command #3004

wants to merge 6 commits into from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 13, 2024

#2927

How do we handle this?

debian/prerm
2: cscli dashboard remove -f -y --error || echo "Ignore the above error if you never installed the local dashboard."

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.05%. Comparing base (57539f6) to head (fe72cce).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
+ Coverage   51.25%   52.05%   +0.80%     
==========================================
  Files         340      336       -4     
  Lines       38771    38020     -751     
==========================================
- Hits        19873    19793      -80     
+ Misses      16942    16273     -669     
+ Partials     1956     1954       -2     
Flag Coverage Δ
bats 41.37% <100.00%> (+0.63%) ⬆️
unit-linux 35.55% <0.00%> (+0.90%) ⬆️
unit-windows 28.96% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the remove-dashboard branch 2 times, most recently from 1541c5a to 6ab7f4d Compare June 3, 2024 07:01
@mmetc mmetc force-pushed the remove-dashboard branch 6 times, most recently from beea707 to 8e65eb2 Compare June 12, 2024 06:24
@mmetc mmetc added this to the 1.7.0 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants