Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source_strings): add branch id parameter to add_string #163

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

iaristide
Copy link
Contributor

The add_string method is missing the option to add a branch ID which is required when uploading strings to a string based project in Crowdin.

@iaristide iaristide changed the title add branch id parameter to add_string fix(source_strings): add branch id parameter to add_string Jun 13, 2024
@andrii-bodnar
Copy link
Member

@iaristide thanks for the contribution! Could you please address the failed tests? https://github.com/crowdin/crowdin-api-client-python/actions/runs/9505788246/job/26202226889?pr=163

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iaristide thank you!

@andrii-bodnar andrii-bodnar merged commit bfe6757 into crowdin:main Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants