feat: Add AI Setting Methods #279
Open
+163
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Added methods for AI setting methods for. - reference: https://support.crowdin.com/developer/api/v2/#tag/AI/operation/api.users.ai.settings.get.
|
@vedantnd111 as I can see from the failed CI build, there is an issue in the tests code: > Task :compileTestJava
/home/runner/work/crowdin-api-client-java/crowdin-api-client-java/src/test/java/com/crowdin/client/ai/AiApiTest.java:25: error: cannot find symbol
return List.of(RequestMock.build(settingsApi, HttpGet.METHOD_NAME, "api/ai/getAiSettingResponse.json"),
^
symbol: method of(RequestMock,RequestMock)
location: interface List
|
I have made some changes to fix this. Please check. |
timiredmind
reviewed
Oct 13, 2024
|
|
||
| @Test | ||
| public void getAiSettingTest() { | ||
| System.out.println("test-url: " + settingsApi); |
There was a problem hiding this comment.
You might want to remove this line of code
There was a problem hiding this comment.
Removed log statments, but tests are failing because received response is null. I was not able to debug this, could you PTAL?
|
@vedantnd111 i think it will be better to have a single commit |
|
@vedantnd111 the CI is failing: > Task :test
AiApiTest > getAiSettingTest() FAILED
org.opentest4j.AssertionFailedError at AiApiTest.java:35
AiApiTest > editAiSettingTest() FAILED
org.opentest4j.AssertionFailedError at AiApiTest.java:48
364 tests completed, 2 failedPlease take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: