Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added SecurityLogs Related APIs #223

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

Durdush
Copy link
Contributor

@Durdush Durdush commented Feb 4, 2024

No description provided.

@Durdush Durdush changed the title Added SecurityLogs Related APIs Feat: Added SecurityLogs Related APIs Feb 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (bc990f7) 80.86% compared to head (4e3ca65) 81.03%.
Report is 5 commits behind head on master.

Files Patch % Lines
...m/crowdin/client/securitylogs/SecurityLogsApi.java 92.00% 2 Missing ⚠️
src/main/java/com/crowdin/client/Client.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #223      +/-   ##
============================================
+ Coverage     80.86%   81.03%   +0.17%     
- Complexity      569      575       +6     
============================================
  Files           171      173       +2     
  Lines          2168     2203      +35     
  Branches         49       49              
============================================
+ Hits           1753     1785      +32     
- Misses          386      389       +3     
  Partials         29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Durdush Durdush changed the title Feat: Added SecurityLogs Related APIs feat: Added SecurityLogs Related APIs Feb 4, 2024
@andrii-bodnar andrii-bodnar linked an issue Feb 5, 2024 that may be closed by this pull request
Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Durdush thank you!

The Crowdin Enterprise Security logs API methods are not covered by this PR. Please take a look.

Use this as a reference - crowdin/crowdin-api-client-dotnet#222

It has separate methods for User Security Logs and Organization Security Logs: ListUserSecurityLogs, GetUserSecurityLog, ListOrganizationSecurityLogs, GetOrganizationSecurityLog. A similar approach can be used in the Java API Client.

@Durdush
Copy link
Contributor Author

Durdush commented Feb 5, 2024

Okay,Sure. Will check.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Durdush thank you!

@andrii-bodnar andrii-bodnar merged commit 9a4d5ad into crowdin:master Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Logs API support
3 participants