fix: 'unassignLabelFromStrings' - 'stringIds' parameter

crowdin · Jul 26, 2023 · cb43a45 · cb43a45
1 parent e6d9014
commit cb43a45
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/main/java/com/crowdin/client/labels/LabelsApi.java b/src/main/java/com/crowdin/client/labels/LabelsApi.java
@@ -133,15 +133,20 @@ public ResponseList<SourceString> assignLabelToStrings(Long projectId, Long labe
     /**
      * @param projectId Project Identifier
      * @param labelId Label Identifier
+     * @param stringIds List of string IDs
      * @return Source string
      * @see <ul>
      * <li><a href="https://developer.crowdin.com/api/v2/#operation/api.projects.labels.strings.deleteMany" target="_blank"><b>API Documentation</b></a></li>
      * <li><a href="https://developer.crowdin.com/enterprise/api/v2/#operation/api.projects.labels.strings.deleteMany" target="_blank"><b>Enterprise API Documentation</b></a></li>
      * </ul>
      */
-    public ResponseList<SourceString> unassignLabelFromStrings(Long projectId, Long labelId) throws HttpException, HttpBadRequestException {
+    public ResponseList<SourceString> unassignLabelFromStrings(Long projectId, Long labelId, List<Long> stringIds) throws HttpException, HttpBadRequestException {
         String builtUrl = String.format("%s/projects/%d/labels/%d/strings", this.url, projectId, labelId);
-        SourceStringResponseList response = this.httpClient.delete(builtUrl, new HttpRequestConfig(), SourceStringResponseList.class);
+        Map<String, Optional<Object>> queryParams = HttpRequestConfig.buildUrlParams(
+          "stringIds", Optional.ofNullable(stringIds == null ? null : stringIds.stream().map(String::valueOf).collect(Collectors.joining(","))
+        ));
+
+        SourceStringResponseList response = this.httpClient.delete(builtUrl, new HttpRequestConfig(queryParams), SourceStringResponseList.class);
         return SourceStringResponseList.to(response);
     }
 

diff --git a/src/test/java/com/crowdin/client/labels/LabelsApiTest.java b/src/test/java/com/crowdin/client/labels/LabelsApiTest.java
@@ -118,7 +118,7 @@ public void assignLabelToStringTest() {
 
     @Test
     public void unassignLabelToStringTest() {
-        ResponseList<SourceString> response = this.getLabelsApi().unassignLabelFromStrings(projectId, labelId);
+        ResponseList<SourceString> response = this.getLabelsApi().unassignLabelFromStrings(projectId, labelId, Arrays.asList(1L, 2L));
         assertEquals(1, response.getData().size());
     }