allow unmanaged NICs #1117
Open
allow unmanaged NICs #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 23, 2017
| nic.destroy | ||
|
|
||
| nicfiles.each do |file| | ||
| ::File.delete(file) if ::File.exists?(file) |
There was a problem hiding this comment.
Lint/DeprecatedClassMethods: File.exists? is deprecated in favor of File.exist?.
|
|
||
| # Ignore unmanaged interfaces | ||
| nicfiles.each do |file| | ||
| return if system("fgrep", "-q", "#unmanaged", file) |
There was a problem hiding this comment.
Lint/NonLocalExitFromIterator: Non-local exit from iterator, without return value. next, break, Array#find, Array#any?, etc. is preferred.
|
I'm nearly sure we wanted to do that in network.json... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
We want to allow network interfaces that are not managed by chef
How does it address the issue?
we keep interfaces around when the config file has an "#unmanaged" marker comment
Is there additional information worth sharing like links to a Trello
card, bug references, testing advice or dependencies to other pull
requests?
vuntz said, there is a FATE or bug for this
and also Bernhard needs this for running SOC on multicast-vxlan overlay networks where the underlying NIC (e.g. eth0) still needs to work.
This also includes a cleanup commit that is useful without the 2nd one