Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

[Hooks] change the sample installer with RS runtime to MSI format #32

Merged
merged 1 commit into from
Mar 29, 2016

Conversation

DonnaWuDongxia
Copy link
Contributor

BUG=XWALK-6448

@DonnaWuDongxia
Copy link
Contributor Author

@huningxin Please help to review.

@huningxin
Copy link
Contributor

@DonnaWuDongxia , thanks for this PR!

I downloaded the sample_installers.zip from https://ci.appveyor.com/project/recbuilder/realsense-extensions-crosswalk-a87d8/build/19.6.0.109/artifacts, but it doesn't contains the installer with runtime. Did I miss anything?

@DonnaWuDongxia
Copy link
Contributor Author

@huningxin Oh, we need to update the App-tools to include this PR: crosswalk-project/crosswalk-app-tools#118

Because we used the kept .wxs file in the temp folder.
Buildbot failed to package the installer, see following site:
https://ci.appveyor.com/project/recbuilder/realsense-extensions-crosswalk-a87d8/build/19.6.0.109

@huningxin
Copy link
Contributor

@DonnaWuDongxia , thanks for investigation. Can you get it updated in this PR? You may need to refer to 5825786, to change back to master install.

@DonnaWuDongxia
Copy link
Contributor Author

@huningxin Please help to check again.

@huningxin
Copy link
Contributor

Verified. Works great! Thanks!

LGTM and Merging.

@leonhsl , you may need to check whether the binary sign still works with msi installer. Thanks!

@huningxin huningxin merged commit a90b77a into crosswalk-project:master Mar 29, 2016
@leonhsl
Copy link
Contributor

leonhsl commented Mar 29, 2016

I verified that now we only need to sign the MSI installers directly.
Also updated wiki page https://github.com/otcshare/realsense-extensions-crosswalk/wiki/Sign-binaries

@huningxin
Copy link
Contributor

Great! Thanks @leonhsl !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants