[Extensions] Add allow-modals to the default sandbox CSP

BUG=560226 [email protected] Review URL: https://codereview.chromium.org/1482243004 Cr-Commit-Position: refs/heads/master@{#362509} (cherry picked from commit dbadb4c) Review URL: https://codereview.chromium.org/1495233004 . Cr-Commit-Position: refs/branch-heads/2564@{#241} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
crosswalk-project · Dec 4, 2015 · eb90a79 · eb90a79
1 parent f5acc8d
commit eb90a79
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc
@@ -35,7 +35,8 @@ TEST_F(SandboxedPagesManifestTest, SandboxedPages) {
   scoped_refptr<Extension> extension5(
       LoadAndExpectSuccess("sandboxed_pages_valid_5.json"));
 
-  const char kSandboxedCSP[] = "sandbox allow-scripts allow-forms allow-popups";
+  const char kSandboxedCSP[] =
+      "sandbox allow-scripts allow-forms allow-popups allow-modals";
   const char kDefaultCSP[] =
       "script-src 'self' blob: filesystem: chrome-extension-resource:; "
       "object-src 'self' blob: filesystem:;";

diff --git a/extensions/common/manifest_handlers/sandboxed_page_info.cc b/extensions/common/manifest_handlers/sandboxed_page_info.cc
@@ -22,7 +22,7 @@ namespace keys = extensions::manifest_keys;
 namespace errors = manifest_errors;
 
 const char kDefaultSandboxedPageContentSecurityPolicy[] =
-    "sandbox allow-scripts allow-forms allow-popups";
+    "sandbox allow-scripts allow-forms allow-popups allow-modals";
 
 static base::LazyInstance<SandboxedPageInfo> g_empty_sandboxed_info =
     LAZY_INSTANCE_INITIALIZER;