Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quickstart-subnet location patch #812

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

jaymiracola
Copy link
Contributor

This is an unnecessary patch that breaks the composition.

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 08c46c7
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/66e46db8c4b06a0008660b28
😎 Deploy Preview https://deploy-preview-812--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🟢 up 9 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good from cross referencing the resource with its entry in the marketplace. Go ahead and copy this content to the content/v1.17 directory also so it shows up in the latest docs. Thanks @jaymiracola! 🙇‍♂️

@@ -401,15 +401,6 @@ spec:
matchControllerRef: true
resourceGroupNameSelector:
matchControllerRef: true
patches:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah interesting, it does look like Subnet is the only resource in this composition that doesn't have a spec.forProvider.location field. Nice catch!

https://marketplace.upbound.io/providers/upbound/provider-azure-network/v1.5.0/resources/network.azure.upbound.io/Subnet/v1beta1

@jbw976
Copy link
Member

jbw976 commented Sep 12, 2024

Oh and also please add the DOC sign-off to your commit too!

https://github.com/crossplane/crossplane/tree/main/contributing#certificate-of-origin

@jaymiracola
Copy link
Contributor Author

@jbw976 Ive got the second commit signed, but maybe the first needs to be as well?

@jbw976
Copy link
Member

jbw976 commented Sep 13, 2024

yep exactly @jaymiracola, from https://github.com/crossplane/docs/pull/812/checks:

Commit sha: 8fa447c, Author: Jay Miracola, Committer: GitHub; The sign-off is missing.

You could amend that first commit also, or just squash them into a single commit with a sign-off. Let me know if you'd like any help with that!

jaymiracola and others added 2 commits September 13, 2024 12:51
This is an unnecessary patch that breaks the composition.

Signed-off-by: Jay Miracola <[email protected]>
Signed-off-by: Jay Miracola <[email protected]>
@jaymiracola
Copy link
Contributor Author

Thanks @jbw976 ! hopefully its all set now 😅

@jbw976 jbw976 merged commit 8ebeec1 into crossplane:master Sep 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants