-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove quickstart-subnet location patch #812
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good from cross referencing the resource with its entry in the marketplace. Go ahead and copy this content to the content/v1.17
directory also so it shows up in the latest
docs. Thanks @jaymiracola! 🙇♂️
@@ -401,15 +401,6 @@ spec: | |||
matchControllerRef: true | |||
resourceGroupNameSelector: | |||
matchControllerRef: true | |||
patches: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah interesting, it does look like Subnet
is the only resource in this composition that doesn't have a spec.forProvider.location
field. Nice catch!
Oh and also please add the DOC sign-off to your commit too! https://github.com/crossplane/crossplane/tree/main/contributing#certificate-of-origin |
@jbw976 Ive got the second commit signed, but maybe the first needs to be as well? |
yep exactly @jaymiracola, from https://github.com/crossplane/docs/pull/812/checks:
You could amend that first commit also, or just squash them into a single commit with a sign-off. Let me know if you'd like any help with that! |
This is an unnecessary patch that breaks the composition. Signed-off-by: Jay Miracola <[email protected]>
Signed-off-by: Jay Miracola <[email protected]>
66d3626
to
08c46c7
Compare
Thanks @jbw976 ! hopefully its all set now 😅 |
This is an unnecessary patch that breaks the composition.