Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all Vale errors #810

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Fix all Vale errors #810

merged 2 commits into from
Sep 11, 2024

Conversation

jbw976
Copy link
Member

@jbw976 jbw976 commented Sep 9, 2024

This PR fixes all 674 errors from Vale that I could find by running the tooling locally, as described in the contributing guide:
https://docs.crossplane.io/contribute/vale/

❯ vale --config="utils/vale/.vale.ini" content/
... <warnings omitted> ...
✖ 0 errors, 1525 warnings and 0 suggestions in 194 files.

Hopefully, this clean and error free slate will improve the contributor experience so that when folks submit their own PRs they are only faced with Vale errors that they have introduced.

Signed-off-by: Jared Watts <[email protected]>
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit d9f28cf
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/66df8d817d85a90008d6f1a2
😎 Deploy Preview https://deploy-preview-810--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🟢 up 1 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jbw976
Copy link
Member Author

jbw976 commented Sep 10, 2024

lol Vale, I see you don't want to go down without a fight! ⚔️ 🛡️
https://github.com/crossplane/docs/actions/runs/10783172908/job/29904534358?pr=810

✖ 12 errors, 1544 warnings and 0 suggestions in 44 files.

Signed-off-by: Jared Watts <[email protected]>
@jbw976
Copy link
Member Author

jbw976 commented Sep 10, 2024

Ah nice, after bumping Value to v3.7.1 in CI, it also now reports 0 errors:

✖ 0 errors, 1524 warnings and 0 suggestions in 45 files.

@jbw976 jbw976 merged commit 15c896d into crossplane:master Sep 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants