Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve typography, spacing, and accordions #517

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

shanecmiller23
Copy link
Contributor

@shanecmiller23 shanecmiller23 commented Aug 4, 2023

  • Improve typography sizing and font-weight
  • Improve spacing between titles
  • Fix accordions to adhere to dark mode, and improve their styling with hover state
    (accordion example can be found under "Hide long outputs" under /contribute/features/)

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 6621db6
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/64cd223edff5cc0008f9cff0
😎 Deploy Preview https://deploy-preview-517--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shanecmiller23
Copy link
Contributor Author

Due to commit issues from my last PR, I opened up this new one with those changes

@jeanduplessis - I discovered a couple font sizes weren't properly applying. That's fixed now so might be worth another quick look-through at the titles specifically

@jbw976 The "Accordions" I refer to in the commit are these expandable components in this screenshot:
Screenshot 2023-08-04 at 9 11 58 AM

Copy link
Collaborator

@jeanduplessis jeanduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked a whole bunch of pages and they all looked good 👍

@jeanduplessis jeanduplessis merged commit 9cd6330 into crossplane:master Aug 4, 2023
6 checks passed
@jbw976
Copy link
Member

jbw976 commented Aug 5, 2023

The "Accordions" I refer to in the commit are these expandable components in this screenshot:

ah thanks @shanecmiller23, so an Accordion is what I have been calling "expand box" in #480

This PR is merged now and made changes to the accordions, but I still feel like there is some work to make them visible and discoverable. It's still too easy to be scrolling on a page and completely miss these accordions IMO.

Perhaps that can be done with a specific focus on #480?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants