Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tags for new GA version #501

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Update tags for new GA version #501

merged 1 commit into from
Jul 27, 2023

Conversation

plumbis
Copy link
Collaborator

@plumbis plumbis commented Jul 27, 2023

updates the google analytics tag for the new google analytics 4 requirements.

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 049c2d4
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/64c1cac3b5b085000884a298
😎 Deploy Preview https://deploy-preview-501--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

<!-- Google Tag Manager (noscript) -->
<noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-WFF2NQHG" height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this 2nd section is supposed to go in <body> - will this partial layout do that? or will this get incorrectly included into the <head> still instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do things weird-

This file is loaded as part of the footer at the bottom of the body of the page.

The reason for this is to try and load the page a few ms faster without having the non-essential stuff in the way. We may lose a few hits on folks that bail on the page before load, but I'm okay with that if it means faster load times for everyone.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh okay well then if that's the way it's done on this site and we expect this to work correctly still then all good 😊 👍

@plumbis plumbis merged commit 40c435e into crossplane:master Jul 27, 2023
6 checks passed
@plumbis plumbis deleted the gtm branch July 27, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants