Clarify that release dates are approximate #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3 tasks
jeanduplessis
approved these changes
Jul 3, 2023
jeanduplessis
requested changes
Jul 3, 2023
There was a problem hiding this comment.
@jbw976 would you mind having a look at the Vale errors for this new section
86:4 warning 'Release Dates' should use Google.Headings
sentence-style capitalization.
88:12 warning 'is released' may be passive write-good.Passive
voice. Use active voice if you
can.
88:29 warning 'quarterly' is a weasel word! write-good.Weasel
89:1 warning Avoid using future tense: gitlab.FutureTense
"will happen". Use present
tense instead.
90:43 warning Remove this word from the gitlab.Wordy
sentence: "Please".
91:26 warning 'A number of' is too wordy. write-good.TooWordy
Signed-off-by: Jared Watts <[email protected]>
jbw976
force-pushed
the
release-dates
branch
3 times, most recently
from
a7037e0
to
f2e7898
Compare
…es section Signed-off-by: Jared Watts <[email protected]>
|
@jeanduplessis I fixed all Vale errors within the entire doc, and fixed all warnings within this new section: Can you take another look now sir? 🙇 |
jeanduplessis
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up here in the docs from crossplane/crossplane#4211, this PR clarifies that the release dates are approximate and provides reasoning why.