Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume upjet ProviderScheduler #417

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Mar 27, 2023

Description of your changes

This PR reenables the shared gRPC server runtime previously disabled due to external resource leakage issues. It consumes the new provider scheduler from upjet and:

  • Enables the shared server runtime
  • Adds --provider-ttl command-line option through which the max TTL used by the shared scheduler can be configured.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

This PR has been tested in the experiments done here:
#404

The provider package built for this PR is: ulucinar/provider-azure-amd64:v0.29.0-1ed7d5aec

- Add --provider-ttl command-line option

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/network/networkinterface.yaml"

@ulucinar ulucinar requested a review from turkenf March 28, 2023 09:00
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ulucinar LGTM!

@ulucinar ulucinar merged commit b442b8b into crossplane-contrib:main Mar 28, 2023
@ulucinar ulucinar deleted the fix-aws-325 branch March 28, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants