Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add revoke logic to grant pr1 #207

Conversation

olikyr
Copy link
Contributor

@olikyr olikyr commented Jan 7, 2025

Description of your changes

This is a sub PR of
#200

  1. I added a field called revokePublicOnDb in grant resource; if true, it will revoke from public access to DB; This usually a DBA requirement.
  2. I added a field called isPrivate revokePublicOnSchema in schema resource; if true, it will revoke from public access to a schema; This usually a DBA requirement.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

inside the project

make clean
make build
make reviewable

@olikyr olikyr force-pushed the feature/add-revoke-logic-to-grant-pr1 branch from 4072a84 to ddac9e2 Compare January 7, 2025 15:13
… Schema resource isPrivate, added a revoke to database for non-owner users

update mariadb version to be similar to master version
use of HELM varibale instead of HELM3

Signed-off-by: oliver.zokra <[email protected]>
@olikyr olikyr force-pushed the feature/add-revoke-logic-to-grant-pr1 branch from ddac9e2 to 6f2a496 Compare January 7, 2025 15:15
Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the parameters named differently?

@olikyr
Copy link
Contributor Author

olikyr commented Jan 10, 2025

I think you are right about this inconsistency, either they should be both isPrivate, or for schema adopt RevokePublicOnSchema.
I would go with RevokePublicOnSchema and RevokePublicOnDB as we are doing a specific command and I am afraid that private could infer a bigger context.
What do you think?

@Duologic
Copy link
Member

yeah, that's alright

@Duologic Duologic enabled auto-merge (squash) January 13, 2025 09:24
@Duologic Duologic disabled auto-merge January 13, 2025 09:25
Signed-off-by: oliver.zokra <[email protected]>
@Duologic Duologic enabled auto-merge (squash) January 13, 2025 10:49
@Duologic Duologic merged commit fcd50ac into crossplane-contrib:master Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants