Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): Add TaskDefinitionFamily #2121

Merged

Conversation

simwak
Copy link
Contributor

@simwak simwak commented Nov 8, 2024

Description of your changes

Adds an API that manages the updating of an ECS TaskDefinition. It creates a new revision of the TaskDefinition and, when updated, creates a new TaskDefinition and purges the old one.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Unit tests
  • Manual testing (Create, Update, Delete)

@simwak simwak force-pushed the feat/ecs-taskdefinitionfamily branch from 788c413 to 073ffd3 Compare November 8, 2024 10:18
@simwak simwak force-pushed the feat/ecs-taskdefinitionfamily branch from 073ffd3 to 2a578e7 Compare November 8, 2024 11:08
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @simwak!

@MisterMX MisterMX merged commit 45ad7a5 into crossplane-contrib:master Nov 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants