Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kafka): add brokerNodeGroupInfo to atProvider #2059

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented May 13, 2024

Description of your changes

for Cluster.kafka:

  • add brokerNodeGroupInfo to status.atProvider

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

manually

Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <[email protected]>
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @wotolom!

Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <[email protected]>
@wotolom wotolom force-pushed the kafka-atprovider-brokernodegroupinfo branch from 9dd6c0a to d56d28d Compare May 13, 2024 16:53
@MisterMX MisterMX merged commit c3eb942 into crossplane-contrib:master May 14, 2024
9 checks passed
@wotolom wotolom deleted the kafka-atprovider-brokernodegroupinfo branch May 14, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants