Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): Decode policy document before parsing #1789

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

MisterMX
Copy link
Collaborator

Description of your changes

Fixes a bug that was introduced in #1774 which causes reconcile to fail during parsing of an URL-encoded policy document.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Unit tests and the existing examples.

Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <[email protected]>
@MisterMX MisterMX merged commit 6216ce7 into crossplane-contrib:master Jun 22, 2023
@github-actions
Copy link

Backport failed for release-0.40, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-0.40
git worktree add -d .worktree/backport-1789-to-release-0.40 origin/release-0.40
cd .worktree/backport-1789-to-release-0.40
git checkout -b backport-1789-to-release-0.40
ancref=$(git merge-base 632548323529128edbc13e7be35e19cb1dab58f9 58341a021e5c4e826819886abc2a31e3242d3169)
git cherry-pick -x $ancref..58341a021e5c4e826819886abc2a31e3242d3169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants