fix(topic): Improve topic policy json diff check #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! @MisterMX, Can you take a look at this? Thanks in advance. |
|
@x4b1 can you sqash your changes into a single commit and get rid of the merge commit? This would help a lot to keep the history short and concise. |
x4b1
force-pushed
the
master
branch
3 times, most recently
from
9ecd126
to
759fd6d
Compare
Signed-off-by: Xabi <[email protected]>
|
@MisterMX done! |
|
Thanks, @x4b1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In the observed policy on the topic, the comparison of JSON strings was changed to comparing actual JSON objects to prevent the update loop. This way it recognizes that the two objects are the same.
I have:
How has this code been tested
I have added a unit test to check this case.