Merge pull request #2077 from amotolani/feat(cache)-add-readerEndpoin…

…t-to-status feat(replicationGroup): Add readerEndpoint to status
crossplane-contrib · Jul 24, 2024 · 24abbe4 · 24abbe4
2 parents fc5dfe5 + 9cfe9ee
commit 24abbe4
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 0 deletions.
diff --git a/apis/cache/v1beta1/replication_group_types.go b/apis/cache/v1beta1/replication_group_types.go
@@ -93,6 +93,9 @@ type NodeGroup struct {
 	// node group (shard).
 	PrimaryEndpoint Endpoint `json:"primaryEndpoint,omitempty"`
 
+	// ReaderEndpoint is the endpoint of the replica nodes in this node group (shard).
+	ReaderEndpoint Endpoint `json:"readerEndpoint,omitempty"`
+
 	// Slots is the keyspace for this node group (shard).
 	Slots string `json:"slots,omitempty"`
 

diff --git a/apis/cache/v1beta1/zz_generated.deepcopy.go b/apis/cache/v1beta1/zz_generated.deepcopy.go
diff --git a/package/crds/cache.aws.crossplane.io_replicationgroups.yaml b/package/crds/cache.aws.crossplane.io_replicationgroups.yaml
@@ -1096,6 +1096,19 @@ spec:
                                 on.
                               type: integer
                           type: object
+                        readerEndpoint:
+                          description: ReaderEndpoint is the endpoint of the replica
+                            nodes in this node group (shard).
+                          properties:
+                            address:
+                              description: Address is the DNS hostname of the cache
+                                node.
+                              type: string
+                            port:
+                              description: Port number that the cache engine is listening
+                                on.
+                              type: integer
+                          type: object
                         slots:
                           description: Slots is the keyspace for this node group (shard).
                           type: string

diff --git a/pkg/clients/elasticache/elasticache.go b/pkg/clients/elasticache/elasticache.go
@@ -527,6 +527,18 @@ func generateNodeGroup(ng elasticachetypes.NodeGroup) v1beta1.NodeGroup {
 		Slots:       pointer.StringValue(ng.Slots),
 		Status:      pointer.StringValue(ng.Status),
 	}
+	if ng.ReaderEndpoint != nil {
+		r.ReaderEndpoint = v1beta1.Endpoint{
+			Address: pointer.StringValue(ng.ReaderEndpoint.Address),
+			Port:    int(ng.ReaderEndpoint.Port),
+		}
+	}
+	if ng.PrimaryEndpoint != nil {
+		r.PrimaryEndpoint = v1beta1.Endpoint{
+			Address: pointer.StringValue(ng.PrimaryEndpoint.Address),
+			Port:    int(ng.PrimaryEndpoint.Port),
+		}
+	}
 	if len(ng.NodeGroupMembers) != 0 {
 		r.NodeGroupMembers = make([]v1beta1.NodeGroupMember, len(ng.NodeGroupMembers))
 		for i, m := range ng.NodeGroupMembers {

diff --git a/pkg/clients/elasticache/elasticache_test.go b/pkg/clients/elasticache/elasticache_test.go
@@ -585,6 +585,10 @@ func TestGenerateObservation(t *testing.T) {
 				Address: pointer.ToOrNilIfZeroValue("random-12"),
 				Port:    124,
 			},
+			ReaderEndpoint: &elasticachetypes.Endpoint{
+				Address: pointer.ToOrNilIfZeroValue("random-12-ro"),
+				Port:    124,
+			},
 			NodeGroupMembers: []elasticachetypes.NodeGroupMember{
 				{
 					CacheClusterId:            pointer.ToOrNilIfZeroValue("my-cache-cluster"),