Validate Value and ValueFromFieldPath are not nil #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ehsan <[email protected]>
etesami
force-pushed
the
validate-fromcompositepath-or-value
branch
from
0049fb4 to
386d059
Compare
phisco
reviewed
Feb 6, 2025
Signed-off-by: Ehsan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #23
This PR adds validations to ensure proper field selection:
ValueFromFieldPathis selected, thevalueFromFieldPathfield is checked to ensure it is notnil.Valueis selected, thevaluefield is verified to be non-nil.I have: