Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CI to GitHub Actions #489

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Migrate CI to GitHub Actions #489

merged 3 commits into from
Apr 10, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Apr 10, 2020

Replaces #488

@taiki-e taiki-e mentioned this pull request Apr 10, 2020
Closed
@taiki-e taiki-e requested a review from jeehoonkang April 10, 2020 07:31
@jeehoonkang
Copy link
Contributor

I'm happy with the change. Thank you for your detailed analysis: #488 (comment)

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 10, 2020

Build succeeded

@bors bors bot merged commit 0599b8e into master Apr 10, 2020
@taiki-e taiki-e deleted the github-actions branch April 10, 2020 09:44
@jeehoonkang
Copy link
Contributor

Dear @taiki-e,

It seems old PRs not are tested with the new CI, e.g., #485 . Do you happen to know how to test them in the new CI?

@taiki-e
Copy link
Member Author

taiki-e commented Apr 11, 2020

@jeehoonkang
Unfortunately, I think it needs to rebase (or merge master branch to PR's branch).

(However, as bors run the test when merging, if PR is likely to pass the test, we may be able to use bors.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeehoonkang jeehoonkang Awaiting requested review from jeehoonkang

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @jeehoonkang