skiplist: switch to alloc API

[tobz]

This addresses #246 by removing the allocation hack that was in place before.

Signed-off-by: Toby Lawrence [email protected]

[ghost]

Thanks for the PR! We just need to tweak a few things before merging.

[tobz]

@stjepang I think this is all set now.

[tobz]

Hmm, not really sure why it thinks that std::alloc doesn't exist... that's straight out of the Rust docs themselves. O_o

[ghost]

It's because of these shenanigans we use to support no_std + alloc environments. You probably need use alloc::alloc instead of use std::alloc.

[tobz]

Ahhhh, alright. Lemme whip up the fix.

[tobz]

Looks like it's an unrelated crossbeam-channel failure at this point?

[ghost]

That is an unrelated regression on nightly Rust: rust-lang/rust#56867

[SimonSapin]

This needs to check for null and call handle_alloc_error(layout).

[ghost]

Oh, thanks for pointing this out! I'm used to Box::new() always working so the possibility of a failure didn't even cross my mind.

@tobz Would you like to submit a fix for this?

[SimonSapin]

Yeah this a bit of a footgun… eventually we’ll stabilize the Alloc trait with Result return types and deprecate these functions.

[tobz]

I'll submit a fix, yeah.