-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disconnected flavor which immediately fails #1047
Draft
ryoqun
wants to merge
1
commit into
crossbeam-rs:master
Choose a base branch
from
ryoqun:disconnected-channel-flavor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
//! Channel that is always disconnected. | ||
//! | ||
//! Messages cannot be sent into this kind of channel. | ||
|
||
use std::marker::PhantomData; | ||
use std::time::Instant; | ||
|
||
use crate::context::Context; | ||
use crate::err::{RecvTimeoutError, TryRecvError}; | ||
use crate::select::{Operation, SelectHandle, Token}; | ||
|
||
/// This flavor doesn't need a token. | ||
pub(crate) type DisconnectedToken = (); | ||
|
||
/// Channel that always delivers messages. | ||
pub(crate) struct Channel<T> { | ||
_marker: PhantomData<T>, | ||
} | ||
|
||
impl<T> Channel<T> { | ||
/// Creates a channel that always delivers messages. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oops forgot to update.. |
||
#[inline] | ||
pub(crate) fn new() -> Self { | ||
Channel { | ||
_marker: PhantomData, | ||
} | ||
} | ||
|
||
/// Attempts to receive a message without blocking. | ||
#[inline] | ||
pub(crate) fn try_recv(&self) -> Result<T, TryRecvError> { | ||
Err(TryRecvError::Disconnected) | ||
} | ||
|
||
/// Receives a message from the channel. | ||
#[inline] | ||
pub(crate) fn recv(&self, _deadline: Option<Instant>) -> Result<T, RecvTimeoutError> { | ||
Err(RecvTimeoutError::Disconnected) | ||
} | ||
|
||
/// Reads a message from the channel. | ||
#[inline] | ||
pub(crate) unsafe fn read(&self, _token: &mut Token) -> Result<T, ()> { | ||
Err(()) | ||
} | ||
|
||
/// Returns `true` if the channel is empty. | ||
#[inline] | ||
pub(crate) fn is_empty(&self) -> bool { | ||
true | ||
} | ||
|
||
/// Returns `true` if the channel is full. | ||
#[inline] | ||
pub(crate) fn is_full(&self) -> bool { | ||
true | ||
} | ||
|
||
/// Returns the number of messages in the channel. | ||
#[inline] | ||
pub(crate) fn len(&self) -> usize { | ||
0 | ||
} | ||
|
||
/// Returns the capacity of the channel. | ||
#[inline] | ||
pub(crate) fn capacity(&self) -> Option<usize> { | ||
Some(0) | ||
} | ||
} | ||
|
||
impl<T> SelectHandle for Channel<T> { | ||
#[inline] | ||
fn try_select(&self, _token: &mut Token) -> bool { | ||
true | ||
} | ||
|
||
#[inline] | ||
fn deadline(&self) -> Option<Instant> { | ||
None | ||
} | ||
|
||
#[inline] | ||
fn register(&self, _oper: Operation, _cx: &Context) -> bool { | ||
self.is_ready() | ||
} | ||
|
||
#[inline] | ||
fn unregister(&self, _oper: Operation) {} | ||
|
||
#[inline] | ||
fn accept(&self, token: &mut Token, _cx: &Context) -> bool { | ||
self.try_select(token) | ||
} | ||
|
||
#[inline] | ||
fn is_ready(&self) -> bool { | ||
true | ||
} | ||
|
||
#[inline] | ||
fn watch(&self, _oper: Operation, _cx: &Context) -> bool { | ||
self.is_ready() | ||
} | ||
|
||
#[inline] | ||
fn unwatch(&self, _oper: Operation) {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to expand this doccomment with an example, which will be based on the one in the pr description with polishes, once it's confirmed that this pr has some hope to be merged.