Stop using twisted.internet.defer.returnValue #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`defer.returnValue` was only needed in Python 2; in Python 3, a simple `return` is fine. `twisted.internet.defer.returnValue` is deprecated as of Twisted 24.7.0.
|
hi there, thanks for contributing! unfortunately, another case of unrelated issues .. sorry, it is kinda never ending story - due to the complexity of this project, and even though we've tried hard over and over to pin dependencies and what not, well, still not the docs CI failure .. seems like sphinx has a new / more strict check - unrelated to this PR the pypy CI failure -- also unrelated .. nasm too old, wtf, haven't analyzed what change upstream is the origin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defer.returnValuewas only needed in Python 2; in Python 3, a simplereturnis fine.twisted.internet.defer.returnValueis deprecated as of Twisted 24.7.0.